Class ExplicitInitializationCheck

  • All Implemented Interfaces:
    Configurable, Contextualizable

    public class ExplicitInitializationCheck
    extends AbstractCheck

    Checks if any class or object member explicitly initialized to default for its type value (null for object references, zero for numeric types and char and false for boolean.

    Rationale: each instance variable gets initialized twice, to the same value. Java initializes each instance variable to its default value (0 or null) before performing any initialization specified in the code. So in this case, x gets initialized to 0 twice, and bar gets initialized to null twice. So there is a minor inefficiency. This style of coding is a hold-over from C/C++ style coding, and it shows that the developer isn't really confident that Java really initializes instance variables to default values.

    • Field Detail

      • MSG_KEY

        public static final java.lang.String MSG_KEY
        A key is pointing to the warning message text in "messages.properties" file.
        See Also:
        Constant Field Values
      • onlyObjectReferences

        private boolean onlyObjectReferences
        Whether only explicit initialization made to null should be checked.
    • Constructor Detail

      • ExplicitInitializationCheck

        public ExplicitInitializationCheck()
    • Method Detail

      • getDefaultTokens

        public final int[] getDefaultTokens()
        Description copied from class: AbstractCheck
        Returns the default token a check is interested in. Only used if the configuration for a check does not define the tokens.
        Specified by:
        getDefaultTokens in class AbstractCheck
        Returns:
        the default tokens
        See Also:
        TokenTypes
      • getRequiredTokens

        public final int[] getRequiredTokens()
        Description copied from class: AbstractCheck
        The tokens that this check must be registered for.
        Specified by:
        getRequiredTokens in class AbstractCheck
        Returns:
        the token set this must be registered for.
        See Also:
        TokenTypes
      • getAcceptableTokens

        public final int[] getAcceptableTokens()
        Description copied from class: AbstractCheck
        The configurable token set. Used to protect Checks against malicious users who specify an unacceptable token set in the configuration file. The default implementation returns the check's default tokens.
        Specified by:
        getAcceptableTokens in class AbstractCheck
        Returns:
        the token set this check is designed for.
        See Also:
        TokenTypes
      • setOnlyObjectReferences

        public void setOnlyObjectReferences​(boolean onlyObjectReferences)
        Sets whether only explicit initialization made to null should be checked.
        Parameters:
        onlyObjectReferences - whether only explicit initialization made to null should be checked
      • validateNonObjects

        private void validateNonObjects​(DetailAST ast)
        Checks for explicit initializations made to 'false', '0' and '\0'.
        Parameters:
        ast - token being checked for explicit initializations
      • isZeroChar

        private static boolean isZeroChar​(DetailAST exprStart)
        Examine char literal for initializing to default value.
        Parameters:
        exprStart - expression
        Returns:
        true is literal is initialized by zero symbol
      • isSkipCase

        private static boolean isSkipCase​(DetailAST ast)
        Checks for cases that should be skipped: no assignment, local variable, final variables.
        Parameters:
        ast - Variable def AST
        Returns:
        true is that is a case that need to be skipped.
      • isObjectType

        private static boolean isObjectType​(DetailAST type)
        Determines if a given type is an object type.
        Parameters:
        type - type to check.
        Returns:
        true if it is an object type.
      • isNumericType

        private static boolean isNumericType​(int type)
        Determine if a given type is a numeric type.
        Parameters:
        type - code of the type for check.
        Returns:
        true if it's a numeric type.
        See Also:
        TokenTypes
      • isZero

        private static boolean isZero​(DetailAST expr)
        Checks if given node contains numeric constant for zero.
        Parameters:
        expr - node to check.
        Returns:
        true if given node contains numeric constant for zero.